Easier pip install #9821
Easier pip install #9821
Conversation
| pyqt5>=5.10,<5.14; platform_system == "Darwin" | ||
| pyqt5>=5.10,!=5.15.2,!=5.15.3; platform_system == "Linux" | ||
| pyqt5>=5.10,!=5.15.3; platform_system != "Linux" and platform_system != "Darwin" | ||
| pyqt5>=5.10,!=5.15.3; platform_system == "Windows" |
There was a problem hiding this comment.
this is an unrelated change, but elsewhere in requirements.txt we do use platform_system == "Windows" so it seems cleaner to also use it here... unless I'm missing something?
|
ok, this is a little trickier than I thought. It would be easier if we didn't install anything from URLs in our various
Personally I'd be happy to use released versions of so, closing for now, but happy to have input if there's a better way than what I've tried here / if some of the things I've suggested above are deal-breakers for anyone. incidentally, I notice that the |
|
We could start small and just support [data] to make it easier to use dataset fetchers |
|
good idea, I'll do that in a new PR.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
…On Friday, October 8th, 2021 at 7:27 PM, Eric Larson ***@***.***> wrote:
We could start small and just support [data] to make it easier to use dataset fetchers
—
You are receiving this because you modified the open/close state.
Reply to this email directly, [view it on GitHub](#9821 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAN2AU7KCKEKUJSM7KUZFYTUF6D6DANCNFSM5FUG4HBA).
|
Is this a change from previous versions? Does |
|
Is this a change from previous versions? Does mne.datasets require pooch
now?
yes
|
4 participants
following dev discussion, this should allow things like
pip install mne[data]to get just the basics plus what is needed for dataset downloading (numpy, scipy, pooch, tqdm).