Skip to content

MAINT: Pin jsonschema to < 4 to avoid DeprecationWarning #9805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoechenberger merged 1 commit into from
Oct 5, 2021
Merged

MAINT: Pin jsonschema to < 4 to avoid DeprecationWarning #9805

hoechenberger merged 1 commit into from
Oct 5, 2021

Conversation

@hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Oct 5, 2021

@hoechenberger hoechenberger mentioned this pull request Oct 5, 2021
Merged
agramfort
agramfort approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CI failure is unrelated

@hoechenberger
Copy link
Member Author

hoechenberger commented Oct 5, 2021

CI error seems unrelated?

@agramfort @larsoner Could you have a look and merge if you're happy?

@hoechenberger hoechenberger merged commit 61608aa into mne-tools:main Oct 5, 2021
@hoechenberger hoechenberger deleted the fix-ci branch October 5, 2021 08:27
@larsoner
Copy link
Member

larsoner commented Oct 5, 2021

FYI the preferred solution to me, already implemented in #9803 and #9800, is just to ignore the warning in conftest. It's not our problem and we know they'll probably fix it, so a simple ignore is less maintenance work for us here than a version pin we have to keep track of.

@hoechenberger
Copy link
Member Author

hoechenberger commented Oct 5, 2021

Oh, ok, sounds like a reasonable approach too 😅

So … should this PR be reverted…?

@larsoner
Copy link
Member

larsoner commented Oct 5, 2021

I'll fix it in #9803

This was referenced Oct 8, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoechenberger @larsoner @agramfort