[fix #1716] mount /sys and /sys/fs/cgroup for rootless#1718
Closed
coryb wants to merge 1 commit intomoby:masterfrom
Closed
[fix #1716] mount /sys and /sys/fs/cgroup for rootless#1718coryb wants to merge 1 commit intomoby:masterfrom
coryb wants to merge 1 commit intomoby:masterfrom
Conversation
coryb
force-pushed
the
mount-sys-runc-rootless
branch
from
a564f0b to
b4b4b2c
Compare
Signed-off-by: Cory Bennett <cbennett@netflix.com>
coryb
force-pushed
the
mount-sys-runc-rootless
branch
from
b4b4b2c to
c268ca3
Compare
AkihiroSuda
reviewed
Oct 5, 2020
| Destination: "/sys", | ||
| Type: "none", | ||
| Source: "/sys", | ||
| Options: []string{"rbind", "nosuid", "noexec", "nodev", "ro"}, |
Member
There was a problem hiding this comment.
This is insecure
Collaborator
Author
There was a problem hiding this comment.
Hey, sorry, I didnt mean for you to review this yet :) Yeah, I was trying different approaches. This is the only one that works, and as you noted it is insecure. I was not able to finding a way that works while also being secure, so I just tried to fix it on the runc side, opened a PR there: opencontainers/runc#2634
I will likely close this PR and open another one to pull in the runc changes when can get a fix for that merged in.
Collaborator
Author
|
I am closing this PR, I think we can hopefully find a solution in runc to resolve this issue and not require /sys mounts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is simlar to 4b51fbd attempted in #1627 but using
rbindinstead ofbind.bindcaused integration test failures in./frontend/dockerfile.