refactor to use util/bklog.G(ctx) instead logrus. directly#2236
Merged
tonistiigi merged 1 commit intomoby:masterfrom Jul 13, 2021
Merged
refactor to use util/bklog.G(ctx) instead logrus. directly#2236tonistiigi merged 1 commit intomoby:masterfrom
util/bklog.G(ctx) instead logrus. directly#2236tonistiigi merged 1 commit intomoby:masterfrom
Conversation
morlay
force-pushed
the
master
branch
3 times, most recently
from
200441f to
a278098
Compare
tonistiigi
reviewed
Jul 10, 2021
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
Generally looks ok to me. Do I understand correctly that bklog.G(ctx) can be stored as a value and use multiple times to generate a log?
Contributor
Author
Yes, but could only as variable in a function scope |
Contributor
Author
|
tonistiigi
reviewed
Jul 13, 2021
tonistiigi
reviewed
Jul 13, 2021
morlay
force-pushed
the
master
branch
6 times, most recently
from
ee22977 to
b715f9a
Compare
Signed-off-by: Morlay <morlay.null@gmail.com>
AkihiroSuda
approved these changes
Jul 13, 2021
tonistiigi
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too may changes
I'm not sure, Should I add new param
ctx context.Context, specially for public functions