use bklog.G(ctx) instead of logrus directly#3705
Merged
coryb merged 1 commit intomoby:masterfrom Mar 15, 2023
Merged
Conversation
589dba3 to
4478171
Compare
tonistiigi
approved these changes
Mar 15, 2023
Member
tonistiigi
left a comment
There was a problem hiding this comment.
Sorry, looks like this needs a rebase.
cc @morlay
As a follow-up would be good to get a linter rule that checks this (unless there are still valid exceptions).
Member
|
For a linting rule, I think something like jedevc@6377bbb should do the job? |
Signed-off-by: coryb <cbennett@netflix.com>
Collaborator
Author
Thanks, I put in something similar, the line anchors |
tonistiigi
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #2236
I noticed there were several lines in our logs that were missing traceID fields and found they were still using logrus directly.
I have modified a few apis to pass through the context, and in some cases (where a request context was not applicable) I used
bklog.Lalthough I could change that to usebklog.G(context.Background())if that is preferable.