Skip to content

[v0.11] make tracing socket forward error non-fatal#3483

Merged
tonistiigi merged 1 commit intomoby:v0.11from
tonistiigi:v0.11-grpc-path-err
Jan 9, 2023
Merged

[v0.11] make tracing socket forward error non-fatal#3483
tonistiigi merged 1 commit intomoby:v0.11from
tonistiigi:v0.11-grpc-path-err

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

workaround for #3445

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the v0.11-grpc-path-err branch from 301e903 to c5143c0 Compare January 9, 2023 22:08
@tonistiigi tonistiigi merged commit 830288a into moby:v0.11 Jan 9, 2023
@AkihiroSuda
Copy link
Copy Markdown
Member

This doesn't seem merged in the master?

@AkihiroSuda
Copy link
Copy Markdown
Member

Wondering if we can just place it in the same directory as buildkitd.sock

@tonistiigi
Copy link
Copy Markdown
Member Author

This doesn't seem merged in the master?

Wondered if we could maybe do something better. I guess theoretically\ we could do some symlink hack? Maybe something simpler.

Wondering if we can just place it in the same directory as buildkitd.sock

Is there a significant difference?

@AkihiroSuda
Copy link
Copy Markdown
Member

Is there a significant difference?

/run/user/$UID/buildkit/otel-grpc.sock is usually much shorter than $HOME/.local/share/buildkit/otel-grpc.sock

We can probably also omit -grpc

@tonistiigi
Copy link
Copy Markdown
Member Author

I thought weird jenkins path in #3445 could also affect /run/user/$UID but maybe not. I'm ok with changing this but probably still leave a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants