[v0.12.1] cherry-picks#4088
Merged
tonistiigi merged 2 commits intomoby:v0.12from Aug 2, 2023
Merged
Conversation
Member
tonistiigi
commented
Aug 2, 2023
tonistiigi
commented
- [v0.11] make tracing socket forward error non-fatal #3483 (set tracing socket path to runtime dir #4078 (review))
- executor: fix resource sampler goroutine leak #4081
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit c5143c0)
Before this, the runc executor did not close the cgroupRecord when the container exited non-zero, which resulted in goroutines leaking. Signed-off-by: Erik Sipsma <erik@sipsma.dev> (cherry picked from commit fa11bf9)
crazy-max
approved these changes
Aug 2, 2023
jedevc
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.