hack: enhancements and deadcode removal#4048
Merged
crazy-max merged 9 commits intomoby:masterfrom Sep 19, 2023
Merged
Conversation
crazy-max
force-pushed
the
hack-updates
branch
5 times, most recently
from
0f8185b to
5f48dac
Compare
Member
|
Needs rebase |
AkihiroSuda
reviewed
Sep 15, 2023
AkihiroSuda
reviewed
Sep 15, 2023
crazy-max
force-pushed
the
hack-updates
branch
2 times, most recently
from
5981106 to
d506d0c
Compare
crazy-max
force-pushed
the
hack-updates
branch
from
d506d0c to
ef2d7f1
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
This was useful when Buildx was not available but since Docker 23 it should always be there. Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
hack-updates
branch
from
ef2d7f1 to
a536dea
Compare
AkihiroSuda
approved these changes
Sep 18, 2023
This was referenced Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up https://github.com/docker/buildx/pull/1851/files#r1209904937
closes #4233
see individual commits