Skip to content

ci(test): fix unhandled buildkitd tags#4289

Merged
jedevc merged 1 commit intomoby:masterfrom
crazy-max:test-fix-buildkitd-tags
Sep 28, 2023
Merged

ci(test): fix unhandled buildkitd tags#4289
jedevc merged 1 commit intomoby:masterfrom
crazy-max:test-fix-buildkitd-tags

Conversation

@crazy-max
Copy link
Copy Markdown
Member

Reported by @jedevc

This is a regression from #4048: https://github.com/moby/buildkit/actions/runs/6337159614/job/17211754423?pr=4288#step:8:1478

=== Failed
=== FAIL: client TestNydusIntegration/TestBuildExportNydusWithHybrid/worker=containerd (6.35s)
    client_nydus_test.go:79: 
        	Error Trace:	/src/client/client_nydus_test.go:79
        	            				/src/client/client_nydus_test.go:133
        	            				/src/util/testutil/integration/run.go:91
        	            				/src/util/testutil/integration/run.go:205
        	Error:      	Received unexpected error:
        	            	unsupported compression type nydus
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:77
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:198
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/api/services/control.(*controlClient).Solve
        	            		/src/api/services/control/control.pb.go:2208
        	            	github.com/moby/buildkit/client.(*Client).solve.func2
        	            		/src/client/solve.go:258
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:75
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1598
        	            	failed to solve
        	            	github.com/moby/buildkit/client.(*Client).solve.func2
        	            		/src/client/solve.go:273
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:75
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1598
        	Test:       	TestNydusIntegration/TestBuildExportNydusWithHybrid/worker=containerd

As we now build the integration tests image early we need to set BUILDKITD_TAGS at this step.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from jedevc September 28, 2023 11:21
@crazy-max crazy-max marked this pull request as ready for review September 28, 2023 12:55
@jedevc jedevc merged commit e5afd84 into moby:master Sep 28, 2023
@crazy-max crazy-max deleted the test-fix-buildkitd-tags branch September 28, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants