FreeBSD CI: cross-compile binaries#4180
Merged
tonistiigi merged 1 commit intomoby:masterfrom Aug 25, 2023
Merged
Conversation
Sometimes, vagrant provisioning fails on build step. This may be mitigated by factoring the build step out of the vagrant box and cross-compiling FreeBSD binaries instead. This change - Adds steps to setup go, and compile binaries on the host machine - Adjusts vagrant provisioners accordingly Signed-off-by: Artem Khramov <akhramov@pm.me>
akhramov
force-pushed
the
feature/cross-compile-binaries-freebsd-ci
branch
from
672b760 to
d5e5e84
Compare
Merged
tonistiigi
approved these changes
Aug 25, 2023
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
Thanks. If these MacOS machines can easily run docker we could use the Dockerfile instead of manually invoking go: docker buildx bake binaries --set binaries.platform=freebsd/amd64. That would make sure there are no inconsistencies with how we build linux and freebsd binaries.
AkihiroSuda
approved these changes
Aug 25, 2023
This was referenced Aug 31, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, vagrant provisioning fails on build step. This may be mitigated by factoring the build step out of the vagrant box and cross-compiling FreeBSD binaries instead.
This change