Skip to content

ci(test-os): cross build freebsd binaries using the Dockerfile#4191

Merged
crazy-max merged 1 commit intomoby:masterfrom
crazy-max:ci-freebsd-cross-dockerfile
Sep 13, 2023
Merged

ci(test-os): cross build freebsd binaries using the Dockerfile#4191
crazy-max merged 1 commit intomoby:masterfrom
crazy-max:ci-freebsd-cross-dockerfile

Conversation

@crazy-max
Copy link
Copy Markdown
Member

follow-up #4180

@crazy-max crazy-max force-pushed the ci-freebsd-cross-dockerfile branch 2 times, most recently from b629a41 to da62fa0 Compare August 31, 2023 13:51
@tonistiigi
Copy link
Copy Markdown
Member

cc @akhramov

@crazy-max crazy-max marked this pull request as ready for review September 4, 2023 07:06
@tonistiigi
Copy link
Copy Markdown
Member

Not directly related to this PR but for my better understanding: what it the value of
image

I also can't see integration tests for freebsd. If they are missing, don't add in this PR but if I just don't know where to look then you can comment here.

@crazy-max
Copy link
Copy Markdown
Member Author

Not directly related to this PR but for my better understanding: what it the value of

If the remote vagrant box has been updated it will take some time to export the cache:

image

But consecutive builds will be faster if it has not changed:

image

I also can't see integration tests for freebsd. If they are missing, don't add in this PR but if I just don't know where to look then you can comment here.

Indeed we don't run integration tests atm (just smoke one running a Dockerfile). We could probably have a similar matrix to

uses: ./.github/workflows/.test.yml
with:
cache_scope: build-integration-tests
pkgs: ./client ./cmd/buildctl ./worker/containerd ./solver ./frontend
kinds: integration
codecov_flags: core
includes: |
- pkg: ./...
skip-integration-tests: 1
typ: integration gateway
- pkg: ./client
worker: containerd
tags: nydus
typ: integration
- pkg: ./client
worker: oci
tags: nydus
typ: integration
- pkg: ./...
tags: nydus
skip-integration-tests: 1
typ: integration
running inside the vagrant box. Don't think we can use a freebsd variant for our integration tests image though.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the ci-freebsd-cross-dockerfile branch from da62fa0 to 1c491fb Compare September 9, 2023 07:27
@crazy-max crazy-max merged commit 4dcd141 into moby:master Sep 13, 2023
@crazy-max crazy-max deleted the ci-freebsd-cross-dockerfile branch September 13, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants