Conversation
|
Thanks. Please add a signed off by (I wonder where our bot has gotten too...) and while you are there editing the commit message please paste in the original error for the logs. |
ijc
left a comment
ijc
left a comment
There was a problem hiding this comment.
Needs updating as commented above (GH won't let me set that flag without this redundant comment).
|
@ijc I don't understand what I'm missing. I added the sign off and error message to the commit message. |
ijc
left a comment
ijc
left a comment
There was a problem hiding this comment.
Sorry, seems I missed that you had already made the changes (no notification mail from GH for some reason) so I just wanted to block the merge while our S-o-b bot is being fixed.
This LGTM now, but CI is broken for unrelated reasons. I'm investigating in #202.
|
I've added a workaround for the CI breakage in #202 which has now been merged. Please rebase onto current master to pickup the change and force push the change to your branch here. Sorry for the inconvenience. |
|
@ijc Done and done |
ijc
left a comment
ijc
left a comment
There was a problem hiding this comment.
Thanks. However you seem to have merged rather than rebased. If you did git pull before then git pull --rebase will probably do the right thing, otherwise a git fetch «remote» && git rebase «remote»/master (where «remote» is the upstream remote not your fork) should do the trick.
|
Oh FFS, now something else is wrong with CI. Sorry, please bear with me. |
|
#207 is merged, please rebase again (sorry) or let me know if you would like me to carry the change. |
Original error: error: format specifies type 'ssize_t' (aka 'long') but the argument has type 'off_t' (aka 'long long') Signed-off-by: Charlie Moad <charlie@andcostello.com>
|
CI (finally) green, merging. Thanks for you contribution and your patience! |
2 participants
Resolves #200