Skip to content

Manually upgrade Python to avoid brew failures#202

Merged
ijc merged 1 commit intomoby:masterfrom
ijc:debug
Apr 10, 2018
Merged

Manually upgrade Python to avoid brew failures#202
ijc merged 1 commit intomoby:masterfrom
ijc:debug

Conversation

@ijc
Copy link
Collaborator

@ijc ijc commented Apr 9, 2018

It looks like perhaps some sort of upgrade rename around Python/Python 3 has
gone on so I'm hoping this might help.

Deliberately not signed off (yet) because I think our bot is broken and I want to
test that too.

@ijc ijc force-pushed the debug branch 2 times, most recently from 81e85ca to 96ea97d Compare April 9, 2018 16:12
This can/should be reverted once CircleCI's base image is updated with the
latest brew.

Signed-off-by: Ian Campbell <ijc@docker.com>
@ijc ijc changed the title Manually install Python to investigate CI failures Manually upgrade Python to avoid brew failures Apr 10, 2018
@ijc
Copy link
Collaborator Author

ijc commented Apr 10, 2018

I've converted this into a proper workaround (details in the new code comment) for now, please review.

I'll raise a reverting PR as soon as this is merged to provide a canary for the base image being fixed.

Copy link
Member

@rn rn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How tedious. Hopefully it passes CI. Thanks for looking into this

@ijc ijc merged commit 2e3f12e into moby:master Apr 10, 2018
@ijc ijc deleted the debug branch April 10, 2018 09:57
ijc pushed a commit to ijc/hyperkit that referenced this pull request Apr 10, 2018
This reverts f55b544 which was added in moby#202.

Signed-off-by: Ian Campbell <ijc@docker.com>
ijc pushed a commit to ijc/hyperkit that referenced this pull request Apr 10, 2018
Also revert the Python workaround from f55b544
which was added in moby#202.

Signed-off-by: Ian Campbell <ijc@docker.com>
ijc pushed a commit to ijc/hyperkit that referenced this pull request Apr 10, 2018
Also revert the Python workaround from f55b544
which was added in moby#202.

Signed-off-by: Ian Campbell <ijc@docker.com>
ijc pushed a commit to ijc/hyperkit that referenced this pull request Apr 10, 2018
This reverts f55b544 which was added in moby#202.

Signed-off-by: Ian Campbell <ijc@docker.com>
ijc pushed a commit to ijc/hyperkit that referenced this pull request May 1, 2018
This reverts f55b544 which was added in moby#202.

Signed-off-by: Ian Campbell <ijc@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants