Spelling #1773
Closed
Spelling #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* addresses * assigned * at least * attachments * auxiliary * available * cleanup * communicate * communications * configuration * connection * connectivity * destination * encountered * endpoint * example * existing * expansion * expected * external * forwarded * gateway * implementations * implemented * initialize * internally * loses * message * network * occurred * operational * origin * overlapping * reaper * redirector * release * representation * resolver * retrieve * returns * sanbdox * sequence * succesful * synchronizing * update * validates Signed-off-by: Josh Soref <jsoref@gmail.com>
|
Please sign your commits following these rules: $ git clone -b "spelling" git@github.com:jsoref/libnetwork.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354531088
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Contributor
Author
|
@GordonTheTurtle: this repository does not have the template for commit messages. |
Contributor
|
@jsoref as the bot said, please use the same template as mentioned in https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work (simply add While you're at it could you please squash your commits ? |
Merged
|
carried over by #2229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to actively ignore your submission guidelines.
As a general rule, whenever I submit large changesets to large projects, people insist on changes. As such, there's no point in me signing a submission at this time.
The current summary of each changeset represents a distinct word family misspelling. Sometimes projects have a preferred language family (en-US/en-GB being the most common), as such it's handy to be able to easily drop changesets. It's also not uncommon for some changes to need to be split out into special PRs (e.g. if they would constitute an API change).
I'm happy to squash and sign a single commit once someone agrees it's ready.
I'd appreciate it if someone proposed the commit message. I am not eager to have to sign the commit a second time because someone objects to my chosen commit message.
- What I did
I spellchecked the docker/cli repository
- How I did it
I used my own personal tool to generate a list of tokens not found in
/usr/share/dict/words-- I then manually consider each remaining token. Typically I'll let Google Suggest suggest replacement words.- How to verify it
Review the diff.
- Description for the changelog
changes to 46 word families across
48 files changed, 89 insertions(+), 89 deletions(-)
- A picture of a cute animal (not mandatory but encouraged)
