Skip to content

Spelling #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcrisciani merged 2 commits into from
Jul 12, 2018
Merged

Spelling #2229

fcrisciani merged 2 commits into from
Jul 12, 2018

Conversation

@fcrisciani
Copy link

@fcrisciani fcrisciani commented Jul 11, 2018

Carried over: #1773
And hidden output of check-protobuf:

if [ 1 ]; then \                                                                         
protoc -I=. -I=/go/src -I=/go/src/github.com/gogo/protobuf -I=/go/src/github.com/gogo/protobuf/protobuf --gogo_out=/tmp networkdb/networkdb.proto ; \
diff -q networkdb/networkdb.pb.go /tmp/networkdb/networkdb.pb.go >/dev/null || (echo "👹 networkdb/networkdb.pb.go is out of date; please run 'make protobuf' and check in updates" && exit 1) ; \
else \                                                                                                                                                                                                              protoc -I=. -I=/go/src -I=/go/src/github.com/gogo/protobuf -I=/go/src/github.com/gogo/protobuf/protobuf --gogo_out=./ networkdb/networkdb.proto ; \                                                                
fi                                                                               
if [ 1 ]; then \                                                             
protoc -I=. -I=/go/src -I=/go/src/github.com/gogo/protobuf -I=/go/src/github.com/gogo/protobuf/protobuf --gogo_out=/tmp drivers/windows/overlay/overlay.proto ; \
diff -q drivers/windows/overlay/overlay.pb.go /tmp/drivers/windows/overlay/overlay.pb.go >/dev/null || (echo "👹 drivers/windows/overlay/overlay.pb.go is out of date; please run 'make protobuf' and check in updat
es" && exit 1) ; \                                                                       
else \                                                                       
protoc -I=. -I=/go/src -I=/go/src/github.com/gogo/protobuf -I=/go/src/github.com/gogo/protobuf/protobuf --gogo_out=./ drivers/windows/overlay/overlay.proto ; \                                                     
fi                                                                                                                                                                                                                  
if [ 1 ]; then \                                                                                                        
protoc -I=. -I=/go/src -I=/go/src/github.com/gogo/protobuf -I=/go/src/github.com/gogo/protobuf/protobuf --gogo_out=/tmp drivers/overlay/overlay.proto ; \
diff -q drivers/overlay/overlay.pb.go /tmp/drivers/overlay/overlay.pb.go >/dev/null || (echo "👹 drivers/overlay/overlay.pb.go is out of date; please run 'make protobuf' and check in updates" && exit 1) ; \
else \                                                                                   
protoc -I=. -I=/go/src -I=/go/src/github.com/gogo/protobuf -I=/go/src/github.com/gogo/protobuf/protobuf --gogo_out=./ drivers/overlay/overlay.proto ; \
fi                                                             
if [ 1 ]; then \                                                                                                                                                                                                    
protoc -I=. -I=/go/src -I=/go/src/github.com/gogo/protobuf -I=/go/src/github.com/gogo/protobuf/protobuf --gogo_out=/tmp agent.proto ; \
diff -q agent.pb.go /tmp/agent.pb.go >/dev/null || (echo "👹 agent.pb.go is out of date; please run 'make protobuf' and check in updates" && exit 1) ; \
else \                                                              
protoc -I=. -I=/go/src -I=/go/src/github.com/gogo/protobuf -I=/go/src/github.com/gogo/protobuf/protobuf --gogo_out=./ agent.proto ; \
fi

@fcrisciani fcrisciani mentioned this pull request Jul 11, 2018
Closed
@fcrisciani fcrisciani requested review from ctelfer and euanh July 11, 2018 23:47
ctelfer
ctelfer approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@ctelfer ctelfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsoref and others added 2 commits July 12, 2018 12:54
@jsoref
Spelling fixes
b10559f 
* addresses
* assigned
* at least
* attachments
* auxiliary
* available
* cleanup
* communicate
* communications
* configuration
* connection
* connectivity
* destination
* encountered
* endpoint
* example
* existing
* expansion
* expected
* external
* forwarded
* gateway
* implementations
* implemented
* initialize
* internally
* loses
* message
* network
* occurred
* operational
* origin
* overlapping
* reaper
* redirector
* release
* representation
* resolver
* retrieve
* returns
* sanbdox
* sequence
* succesful
* synchronizing
* update
* validates

Signed-off-by: Josh Soref <jsoref@gmail.com>
Make protobuf check silent
d36e08f 
Avoid printing the if condition

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
@fcrisciani fcrisciani merged commit 0d7e26e into moby:master Jul 12, 2018
@fcrisciani fcrisciani deleted the spelling branch July 12, 2018 20:11
@thaJeztah thaJeztah mentioned this pull request Jun 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@euanh euanh Awaiting requested review from euanh

1 more reviewer

@ctelfer ctelfer ctelfer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fcrisciani @ctelfer @jsoref