Skip to content

[17.06] Add test for cleanupServiceDiscovery #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vieux merged 1 commit into from
Oct 19, 2017
Merged

[17.06] Add test for cleanupServiceDiscovery #1993

vieux merged 1 commit into from
Oct 19, 2017

Conversation

@andrewhsu
Copy link
Contributor

@andrewhsu andrewhsu commented Oct 19, 2017

Backport:

With cherry-pick of 52a9ab5:

$ git cherry-pick -s -x 52a9ab5

No conflicts.

@andrewhsu
Add test for cleanupServiceDiscovery
c1d7bec 
Unit test for the cleanupServiceDiscovery,
follow up of PR: #1985

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
(cherry picked from commit 52a9ab5)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu
Copy link
Contributor Author

andrewhsu commented Oct 19, 2017

cc @fcrisciani @vieux

vieux
vieux approved these changes Oct 19, 2017
View reviewed changes
Copy link
Contributor

@vieux vieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green.

@vieux vieux merged commit 30bdf66 into moby:bump_17.06 Oct 19, 2017
@andrewhsu andrewhsu deleted the t branch October 19, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vieux vieux vieux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewhsu @vieux