Skip to content

Conversation

@fcrisciani
Copy link

@fcrisciani fcrisciani commented Jan 10, 2018

The netlink deserialize is fetching information for the link.
This require the go routine to be in the correct namespace to
succeed

Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com

The netlink deserialize is fetching information from the link.
This require the go routine to be in the correct namespace to
succeed

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
Copy link
Contributor

@abhi abhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcrisciani
Copy link
Author

Fixes #2045

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@315a076). Click here to learn what that means.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2051   +/-   ##
=========================================
  Coverage          ?   40.45%           
=========================================
  Files             ?      138           
  Lines             ?    22160           
  Branches          ?        0           
=========================================
  Hits              ?     8965           
  Misses            ?    11877           
  Partials          ?     1318
Impacted Files Coverage Δ
drivers/overlay/ov_network.go 2.8% <41.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315a076...1717eee. Read the comment docs.

Copy link
Contributor

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants