[Backport 17.12] watchMiss fixes #2052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcrisciani
commented
Jan 10, 2018
fcrisciani
commented
- (Remove watchMiss for swarm mode #2047) removes watchMiss for swarm mode
- (Fix watchMiss thread context #2051) set the proper thread context for watchMiss for swarm classic cases. The upgrade of the netlink library introduced further operations that requires the watchMiss to be set in the proper namespace.
added 2 commits
January 10, 2018 13:52
Swarm mode does not really have anymore a use for the watchMiss. Peer entries are configured at configuration time. If the gcthresh denies the insertion the peerAdd will fail. Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 3d9a808)
The netlink deserialize is fetching information from the link. This require the go routine to be in the correct namespace to succeed Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 1717eee)
Codecov Report
@@ Coverage Diff @@
## bump_17.12 #2052 +/- ##
==============================================
- Coverage 40.18% 40.07% -0.12%
==============================================
Files 138 138
Lines 22135 22139 +4
==============================================
- Hits 8895 8872 -23
- Misses 11935 11963 +28
+ Partials 1305 1304 -1
Continue to review full report at Codecov.
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.