Add a method to retrieve the sandbox interfaces in use#465
Closed
boucher wants to merge 1 commit intomoby:masterfrom
Closed
Add a method to retrieve the sandbox interfaces in use#465boucher wants to merge 1 commit intomoby:masterfrom
boucher wants to merge 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Hui Kang <hkang.sunysb@gmail.com>
Contributor
|
@boucher circle-ci failed. retrying... |
Author
|
Thanks, looks like it passed the second time :) |
Contributor
There was a problem hiding this comment.
This would return all the interfaces in the sandbox, also the one connecting to other endpoints.
Since this function belongs to Endpoint API, I'd expect it to return only the interface owned by this Endpoint.
If the goal instead is to get all the interfaces on the sandbox, I think we should wait for #365 to be merged and add the new API to the Sandbox interface.
Contributor
Author
|
Sure, let me take a look at what that involves. |
Contributor
|
Thanks ! |
Contributor
Author
|
@huikang That would be great. |
Contributor
|
Closing as #518 is a rework of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang hkang.sunysb@gmail.com