Skip to content

Add a method to retrieve the sandbox interfaces in use#465

Closed
boucher wants to merge 1 commit intomoby:masterfrom
boucher:huikang-patch
Closed

Add a method to retrieve the sandbox interfaces in use#465
boucher wants to merge 1 commit intomoby:masterfrom
boucher:huikang-patch

Conversation

@boucher
Copy link

@boucher boucher commented Aug 20, 2015

Signed-off-by: Hui Kang hkang.sunysb@gmail.com

Signed-off-by: Hui Kang <hkang.sunysb@gmail.com>
@mavenugo
Copy link
Contributor

@boucher circle-ci failed. retrying...

@boucher
Copy link
Author

boucher commented Aug 20, 2015

Thanks, looks like it passed the second time :)

@aboch aboch mentioned this pull request Aug 21, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would return all the interfaces in the sandbox, also the one connecting to other endpoints.
Since this function belongs to Endpoint API, I'd expect it to return only the interface owned by this Endpoint.

If the goal instead is to get all the interfaces on the sandbox, I think we should wait for #365 to be merged and add the new API to the Sandbox interface.

@aboch
Copy link
Contributor

aboch commented Sep 10, 2015

@boucher Now that #365 is merged, are you planning to modify this PR to add the new method to the Sandbox interface instead of the Endpoint interface ?

@boucher
Copy link
Author

boucher commented Sep 10, 2015

Sure, let me take a look at what that involves.

@aboch
Copy link
Contributor

aboch commented Sep 10, 2015

Thanks !

@huikang
Copy link
Contributor

huikang commented Sep 11, 2015

@aboch yes, the goal is to get all the interfaces of the containers.
@boucher I can update the PR to move the function to sandbox interface based on #365 if you do not mind.

@boucher
Copy link
Author

boucher commented Sep 11, 2015

@huikang That would be great.

@aboch
Copy link
Contributor

aboch commented Sep 16, 2015

Closing as #518 is a rework of this PR.

@aboch aboch closed this Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants