Skip to content

Add a method to retrieve the interfaces in a sandbox#518

Closed
huikang wants to merge 1 commit intomoby:masterfrom
huikang:huikang-patch
Closed

Add a method to retrieve the interfaces in a sandbox#518
huikang wants to merge 1 commit intomoby:masterfrom
huikang:huikang-patch

Conversation

@huikang
Copy link
Contributor

@huikang huikang commented Sep 11, 2015

Signed-off-by: Hui Kang hkang.sunysb@gmail.com

@huikang
Copy link
Contributor Author

huikang commented Sep 11, 2015

@boucher @aboch
Rebase #465 on the latest libnetwork and move the function to sandbox

Signed-off-by: Hui Kang hkang.sunysb@gmail.com
@boucher
Copy link

boucher commented Sep 15, 2015

@aboch @mavenugo any feedback on this proposal?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though Interface is exposed as an osl interface, it feels odd to include it as part of the API.
osl is purely an internal implementation that provides os layer abstraction away from the clients.
Having this interface exposed via Interfaces() API which gives more control over life-cycle of the interface such as Remove makes me uncomfortable.

Lets hear from @mrjana on his opinion.

@huikang
Copy link
Contributor Author

huikang commented Sep 15, 2015

@boucher @mavenugo I actually created a issue regarding how to checkpoint/restore the container network correct. #524
There, I hope we can design the interface correctly and make some agreement. Thanks.

@mavenugo
Copy link
Contributor

@huikang responded to #524.

@GordonTheTurtle
Copy link

@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

  • For a bug: do you still experience the issue with the latest version?
  • For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to #1926

@corhere corhere closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants