containerd/save: Export only present platform manifests#43966
Closed
thaJeztah wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
thaJeztah
added
status/2-code-review
area/images
thaJeztah
commented
Aug 16, 2022
|
|
||
| // Create a new manifest which contains only the manifests we have in store. | ||
| srcRef := ref.String() | ||
| targetRef := srcRef + "-tmp-export" |
Member
Author
There was a problem hiding this comment.
@vvoland wondering if this needs a more unique name (in case two exports run simultaneously)
Contributor
There was a problem hiding this comment.
Yes, definitely an unique name is needed here.
This is already done in rumpl#56 which also has a bit better implementation of finding out which manifest are present in the store.
Maybe we could hold on a bit with this one and then squash changes so that we don't diverge too much?
Member
Author
There was a problem hiding this comment.
Ah, yes, I could combine both in this PR
Member
Author
There was a problem hiding this comment.
Didn't realize that one was also updating the export code 😅
Member
Author
|
Member
|
Closing this one, all the linked PRs are already upstreamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)