containerd/save: Export only present platform manifests#33
Merged
Conversation
rumpl
reviewed
Aug 1, 2022
| return cs.client.Export(ctx, outStream, opts...) | ||
| } | ||
|
|
||
| func (cs *containerdStore) appendImageForExport(ctx context.Context, is containerdimages.Store, opts []archive.ExportOpt, name string) ([]archive.ExportOpt, error) { |
Owner
There was a problem hiding this comment.
nit: we don't really nee the is parameter, we can use cs.client.ImageService() directly
rumpl
approved these changes
Aug 1, 2022
f9b3d35 to
8a18209
Compare
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
8a18209 to
53f123d
Compare
Collaborator
Author
|
Rebased on the c8d branch |
Collaborator
|
For upstreaming;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to:
Changing
loadto import all platforms breaks the use case:Because exporting the image (even with platform matcher) does export the whole manifest list referencing other platforms blobs (even if we don't have them).
Perhaps that's something that could be worked on upstream - for example adding the flag for
Importto ignore importing the missing blobs? On the other hand the solution in this PR seems a bit better to me - because it feels wrong for the manifest in the archive to reference data it doesn't contain.Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)