Merged
Conversation
This was referenced Jul 28, 2022
thaJeztah
reviewed
Jul 28, 2022
| // fails, fix the difference in the image serialization instead of | ||
| // updating this hash. | ||
| imageTestID := "sha256:11f64303f0f7ffdc71f001788132bca5346831939a956e3e975c93267d89a16d" | ||
| usesContainerdSnapshotter := false // TODO(vvoland): Check for feature flag |
Collaborator
There was a problem hiding this comment.
Drafted a quick PR to add a Features field to docker info, so that we could use that to detect the feature status from the daemon; moby#43880
rumpl
approved these changes
Aug 1, 2022
Closed
The legacy v1 is not supported by the containerd import Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
To make it possible to load emptyfs which is amd64 only Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
containerd-emptyfs-modern
branch
from
3ece20e to
7b41cef
Compare
Collaborator
Author
|
Rebased on the c8d branch |
This was referenced Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
hack/make/.ensure-emptyfshanging because the emptyfs created has the deprecated v1 layout which is not supported by the containerd import.Also changed the
loadbehaviour to load all possible platforms from the archive - emptyfs islinux/amd64.- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)