[ca][17.06] Include a signing profile for cross-signing CA certs externally#2213
Closed
cyli wants to merge 1 commit into
Closed
[ca][17.06] Include a signing profile for cross-signing CA certs externally#2213cyli wants to merge 1 commit into
cyli wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## bump_v17.06.0 #2213 +/- ##
=================================================
+ Coverage 60.11% 60.13% +0.02%
=================================================
Files 119 119
Lines 19849 19850 +1
=================================================
+ Hits 11932 11937 +5
+ Misses 6562 6552 -10
- Partials 1355 1361 +6 |
…quest to external CAs. This way it will be easier for them to implement extra policies. Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
simplify-external-ca-cross-signing-17.06
branch
from
be2d919 to
e9ae19e
Compare
Collaborator
|
LGTM |
Contributor
Author
|
After discussion with @aluzzardi, we aren't going to make PRs against the 17.06 branch. If these can be cherry-picked cleanly, we're just going to merge the master PRs and cherry-pick and push to the 17.06 branch. So since #2212 has been merged, I'll just close this PR and do that. Thanks @aaronlehmann and @diogomonica for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2212 to 17.06 branch.