[manager/allocator] Logging for allocation workflows#2614
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2614 +/- ##
=========================================
+ Coverage 61.72% 61.8% +0.07%
=========================================
Files 134 134
Lines 21770 21781 +11
=========================================
+ Hits 13438 13462 +24
+ Misses 6884 6875 -9
+ Partials 1448 1444 -4 |
nishanttotla
approved these changes
Apr 30, 2018
Contributor
nishanttotla
left a comment
nishanttotla
left a comment
There was a problem hiding this comment.
LGTM.
I don't know that it's a big deal, but maybe this will also be covered in the allocator rewrite? @dperny
Collaborator
|
In the allocator rewrite, everything will be returned as errors from the lower level, and logged at the very top level. |
cyli
approved these changes
Apr 30, 2018
Contributor
cyli
left a comment
cyli
left a comment
There was a problem hiding this comment.
LGTM, although maybe in the method name would we want to include the Allocate object? So something like (*Allocator).allocateTasks, similar to how the dispatcher log messages look?
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
This was referenced May 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to help debug some of the recent issues around tasks stuck in state "new", desired state "running".