[bump_v.17.06] Logging for allocation workflows#2627
Merged
Conversation
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com> (cherry picked from commit bef2bd0) Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
Contributor
Author
|
I'm confident CI failure is due to a flaky test. It was fixed in #2575, but hasn't been cherry-picked into this branch yet. |
Collaborator
|
What's with the stuff added to |
Contributor
Author
|
@dperny CI fails because of the same vendoring issues, so I updated |
Collaborator
|
Alright, LGTM. |
Contributor
Author
|
It's really hard to get the test to pass, so somewhat incorrect to call it flaky I guess, but we're confident that @cyli's fix works. I didn't add it here yet because it doesn't pick cleanly. |
Codecov Report
@@ Coverage Diff @@
## bump_v17.06 #2627 +/- ##
===============================================
+ Coverage 61.68% 67.34% +5.66%
===============================================
Files 42 88 +46
Lines 5692 13375 +7683
===============================================
+ Hits 3511 9008 +5497
- Misses 1842 3433 +1591
- Partials 339 934 +595 |
nishanttotla
force-pushed
the
17.06-logging-fix
branch
2 times, most recently
from
4f82f56 to
3db0625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick #2614
CI failure is due to the flaky test in #2575. I tried cherry picking that, but to make it work, we need to cherry-pick at least #2246 and #2274 (and potentially more PRs?). I spent some time doing that but it became too hairy.
Cherry pick was not clean. Needs quick review.
cc @anshulpundir @chungers @rchourasia