Skip to content

Bump Go to 1.10.3#2636

Merged
cyli merged 1 commit intomoby:masterfrom
thaJeztah:bump-golang-1.10
Jun 28, 2018
Merged

Bump Go to 1.10.3#2636
cyli merged 1 commit intomoby:masterfrom
thaJeztah:bump-golang-1.10

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2018

Codecov Report

Merging #2636 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2636      +/-   ##
=========================================
- Coverage   62.06%   61.8%   -0.27%     
=========================================
  Files         134     134              
  Lines       21740   21740              
=========================================
- Hits        13494   13437      -57     
- Misses       6794    6851      +57     
  Partials     1452    1452

@dperny
Copy link
Copy Markdown
Collaborator

dperny commented May 23, 2018

Nota bene: building fails on OSX, due to a known bug in github.com/google/certificate-transparency-go

vendor/github.com/google/certificate-transparency/go/x509/root_darwin.go:73: cannot use nil as type _Ctype_CFDataRef in assignment

I'm gonna try bumping certificate transparency vendoring locally to see if that clears it up.

Copy link
Copy Markdown
Contributor

@cyli cyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title Bump Go to 1.10.2 Bump Go to 1.10.3 Jun 20, 2018
@thaJeztah
Copy link
Copy Markdown
Member Author

Updated to Go 1.10.3 PTAL

Copy link
Copy Markdown
Contributor

@cyli cyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM - thank you!

@cyli cyli merged commit cf8ac7f into moby:master Jun 28, 2018
@thaJeztah thaJeztah deleted the bump-golang-1.10 branch June 29, 2018 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants