[18.03] migrate to CircleCI 2.0#2696
Merged
dperny merged 4 commits intomoby:bump_v18.03from Jul 9, 2018
Merged
Conversation
Member
Author
|
ping @cyli @anshulpundir @dperny PTAL |
Member
Author
|
Hm, interesting; possibly a change we don't have yet, and causing failure on Go 1.10? |
Member
Author
Signed-off-by: Vincent Robbemond <vincentrobbemond@gmail.com> (cherry picked from commit 06add13) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 0ad63ea) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
and will be removed in August 2018. Signed-off-by: Ying Li <ying.li@docker.com> (cherry picked from commit 19114b4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Ying Li <ying.li@docker.com> (cherry picked from commit 7fc0c4f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
48eee0c to
3ef6334
Compare
Codecov Report
@@ Coverage Diff @@
## bump_v18.03 #2696 +/- ##
===============================================
- Coverage 61.6% 61.29% -0.31%
===============================================
Files 134 134
Lines 21795 21795
===============================================
- Hits 13426 13359 -67
- Misses 6929 6997 +68
+ Partials 1440 1439 -1 |
Member
Author
|
👍 perfect; it's green now 🎉 |
cyli
approved these changes
Jul 9, 2018
Contributor
cyli
left a comment
There was a problem hiding this comment.
Thanks for backporting this @thaJeztah! LGTM
Collaborator
|
Very important, CI would have broken on this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates the 18.03 branch to use CircleCI 2.0, making sure that CI can still run after August. Backports:
cherry-picks were clean