Just use the default GOPATH in CircleCI#2690
Merged
anshulpundir merged 1 commit intomoby:masterfrom Jul 6, 2018
Merged
Conversation
cyli
changed the title
Signed-off-by: Ying Li <ying.li@docker.com>
Contributor
Author
|
Ok ssh'ed in and ran |
thaJeztah
approved these changes
Jul 6, 2018
thaJeztah
requested changes
Jul 6, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
actually; looks like it's failing now? 😢
should I open a vendor PR with this change?
Contributor
Author
|
I think it failed because of my ssh messing around. Trying again. (It also failed due to flakey test previously :|) |
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 61.76% 62.15% +0.39%
==========================================
Files 134 134
Lines 21760 21760
==========================================
+ Hits 13440 13526 +86
+ Misses 6871 6787 -84
+ Partials 1449 1447 -2 |
thaJeztah
approved these changes
Jul 6, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
all green again now, thanks!
LGTM
Member
|
Just cherry-picked this into #2688 to test; and it works! |
johnstep
approved these changes
Jul 6, 2018
| @@ -79,21 +83,21 @@ jobs: | |||
| # The GOPATH setting would not be needed if we used the golang docker image | |||
Member
There was a problem hiding this comment.
Nit: Remove this comment about GOPATH since it is no longer being set?
anshulpundir
approved these changes
Jul 6, 2018
This was referenced Jul 7, 2018
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently CircleCI sets a default GOPATH to
/home/circleci/.go_workspaceso go stuff won't fall back on the default of~/go. So we have to set the environment variable for the whole job. Apparently you can use~but not other environment variables when setting environment variables in CircleCI v2.Anyway, I had set a GOPATH just in case for all our test commands, but I forgot it for the dependency validation, which was why #2688 and #2689 were failing.
Edit: Nm, apparently
~is not valid for environment variables, so I guess we go back to setting the GOPATH for every command, or just go with what CircleCI expects the go path to be I guess, which would hopefully make the circleci script more maintainable (no need to remember to set the GOPATH everywhere)