Skip to content

Update google/certificate-transparency-go to v1.0.10#2688

Merged
cyli merged 1 commit intomoby:masterfrom
thaJeztah:update_certificate_transparency
Jul 25, 2018
Merged

Update google/certificate-transparency-go to v1.0.10#2688
cyli merged 1 commit intomoby:masterfrom
thaJeztah:update_certificate_transparency

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

The current vendor was between v1.0.9 and v1.0.10; this
change switches the dependency to use golang/protobuf instead
of gogo/protobuf.

full diff: google/certificate-transparency-go@5ab67e5...v1.0.10

@thaJeztah
Copy link
Copy Markdown
Member Author

/cc @justincormack @cyli (also see #2689)

@thaJeztah thaJeztah force-pushed the update_certificate_transparency branch from 6835c8a to d234cc4 Compare July 6, 2018 00:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 6, 2018

Codecov Report

Merging #2688 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
- Coverage   61.89%   61.79%   -0.11%     
==========================================
  Files         134      134              
  Lines       21771    21771              
==========================================
- Hits        13476    13453      -23     
- Misses       6836     6867      +31     
+ Partials     1459     1451       -8

@thaJeztah
Copy link
Copy Markdown
Member Author

Something very odd with vendor check in CI; I tried reproducing it locally, but wasn't able to; wondering if it's an issue in CircleCI (either the config or how tests are run)

@thaJeztah
Copy link
Copy Markdown
Member Author

@cyli
Copy link
Copy Markdown
Contributor

cyli commented Jul 6, 2018

I have no idea why, but when I ran the CI build with ssh, it looks like vendor directory is missing a lot of code that is in the vendor.bak directory. I'll try to do some more debugging in the morning. I can't replicate locally either.

@cyli
Copy link
Copy Markdown
Contributor

cyli commented Jul 6, 2018

Update: nm, it's because CircleCI does set the GOPATH variable to something like ~/.go_workspace, so since I set it to something else, I need to set it everywhere.

@thaJeztah thaJeztah force-pushed the update_certificate_transparency branch from 0de48d2 to cedfa1f Compare July 6, 2018 23:34
@thaJeztah
Copy link
Copy Markdown
Member Author

rebased to get rid of the temporary cherry-pick; this should be good to go now

Copy link
Copy Markdown
Contributor

@cyli cyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The current vendor was between v1.0.9 and v1.0.10; this
change switches the dependency to use golang/protobuf instead
of gogo/protobuf.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the update_certificate_transparency branch from cedfa1f to bb9f1fe Compare July 23, 2018 14:54
@cyli cyli merged commit 8580d02 into moby:master Jul 25, 2018
@thaJeztah thaJeztah deleted the update_certificate_transparency branch July 25, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants