Update google/certificate-transparency-go to v1.0.20

[thaJeztah]

This includes a fix to make compilation work on Go 1.11

This PR is based on top of #2688, but kept it separate (as the change is bigger);

• Full diff compared to master: google/certificate-transparency-go@5ab67e5...v1.0.20
• Full diff compared to Update google/certificate-transparency-go to v1.0.10 #2688: google/certificate-transparency-go@v1.0.10...v1.0.20

[thaJeztah]

/cc @justincormack @cyli

[thaJeztah]

rebased to get the CircleCI vendor fix

[thaJeztah]

Interesting; flaky unit test?

--- FAIL: TestRemoveTask (0.01s)
	global_test.go:365: got unexpected event api.EventCreateTask: {Task:&Task{ID:yb6h7e78by4vm4r0y2yevsoj0,Meta:Meta{Version:Version{Index:0,},CreatedAt:(timestamp: nil google_protobuf.Timestamp),UpdatedAt:(timestamp: nil google_protobuf.Timestamp),},Spec:TaskSpec{Runtime:&TaskSpec_Container{Container:&ContainerSpec{Image:,Labels:map[string]string{},Command:[],Args:[],Env:[],Dir:,User:,Mounts:[],StopGracePeriod:(duration: nil google_protobuf1.Duration),PullOptions:nil,Groups:[],Secrets:[],TTY:false,Hostname:,DNSConfig:nil,Healthcheck:nil,Hosts:[],OpenStdin:false,ReadOnly:false,StopSignal:,Configs:[],Privileges:nil,Init:nil,Isolation:ISOLATION_DEFAULT,PidsLimit:0,},},Resources:nil,Restart:&RestartPolicy{Condition:ANY,Delay:50ms,MaxAttempts:0,Window:(duration: nil google_protobuf1.Duration),},Placement:nil,LogDriver:nil,Networks:[],ForceUpdate:0,ResourceReferences:[],},ServiceID:serviceid1,Slot:0,NodeID:nodeid1,Annotations:Annotations{Name:,Labels:map[string]string{},Indices:[],},ServiceAnnotations:Annotations{Name:name1,Labels:map[string]string{},Indices:[],},Status:TaskStatus{Timestamp:2018-07-06T23:42:51.63191555Z,State:NEW,Message:created,Err:,RuntimeStatus:<nil>,PortStatus:nil,AppliedBy:,AppliedAt:(timestamp: nil google_protobuf.Timestamp),},DesiredState:RUNNING,Networks:[],Endpoint:&Endpoint{Spec:nil,Ports:[],VirtualIPs:[],},LogDriver:nil,SpecVersion:nil,AssignedGenericResources:[],} Checks:[]}
FAIL

[codecov]

Codecov Report

Merging #2689 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
+ Coverage   61.68%   61.74%   +0.06%     
==========================================
  Files         134      134              
  Lines       21771    21771              
==========================================
+ Hits        13429    13443      +14     
+ Misses       6890     6882       -8     
+ Partials     1452     1446       -6

[thaJeztah]

ah! green is a nicer color 🎉

[cyli]

LGTM, thanks @thaJeztah!

[kolyshkin]

LGTM

[thaJeztah]

Looks like there's some racy/flaky tests;
https://circleci.com/gh/docker/swarmkit/9343?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

ok  	github.com/docker/swarmkit/manager/orchestrator/global	2.012s	coverage: 82.2% of statements
time="2018-07-23T17:58:06Z" level=error msg="update failed" error="task 6k960q3yuk3tpau0s95vic5ge was already shut down when reached by updater" task.id=quydmkczmw5ct8jifqvqsnow8
--- FAIL: TestUpdaterRollback (4.44s)
    --- FAIL: TestUpdaterRollback/pause/monitor_set/spec_version_set (1.61s)
	Error Trace:	testutils.go:26
			update_test.go:287
			update_test.go:20
	Error:		no task creation
    		

FAIL

[thaJeztah]

Hm. other failure this time;
https://circleci.com/gh/docker/swarmkit/9344?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

ok  	github.com/docker/swarmkit/manager	7.043s	coverage: 82.1% of statements
time="2018-07-23T19:16:12Z" level=error msg="task allocation failure" error="failed to retrieve network testID3 while allocating task testTaskID3"
time="2018-07-23T19:16:13Z" level=error msg="Failed allocation for network testID5" error="failed while allocating driver state for network testID5: could not obtain vxlan id for pool 10.0.4.0/24: requested bit is already allocated"
time="2018-07-23T19:16:13Z" level=error msg="task allocation failure" error="network testID5 attached to task testTaskID6 not allocated yet"
time="2018-07-23T19:16:13Z" level=error msg="Failed allocation for service testServiceID4" error="requested bit is already allocated"
time="2018-07-23T19:16:13Z" level=error msg="task allocation failure" error="service testServiceID4 to which task testTaskID7 belongs has pending allocations"
--- FAIL: TestNodeAllocator (0.04s)
	allocator_test.go:1427: timed out before watchNode found expected node state

[cyli]

@thaJeztah those are known flakey tests, apologies :|

[thaJeztah]

Do we have a list of know. flaky tests? (or individual issues tracking each one)

[cyli]

#2559 for TestUpdaterRollback
#2479 for TestNodeAllocator as well as a raft one on mac os.