Skip to content

[do not merge] Bump golang 1.11beta3#2692

Closed
thaJeztah wants to merge 3 commits intomoby:masterfrom
thaJeztah:bump_golang_1.11
Closed

[do not merge] Bump golang 1.11beta3#2692
thaJeztah wants to merge 3 commits intomoby:masterfrom
thaJeztah:bump_golang_1.11

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

based on top of #2689, to make it compile on Go 1.11; let's see what breaks

@thaJeztah thaJeztah changed the title [do not merge] Bump golang 1.11 [do not merge] Bump golang 1.11beta1 Jul 6, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@496d19b). Click here to learn what that means.
The diff coverage is 40%.

@@            Coverage Diff            @@
##             master    #2692   +/-   ##
=========================================
  Coverage          ?   61.99%           
=========================================
  Files             ?      134           
  Lines             ?    21787           
  Branches          ?        0           
=========================================
  Hits              ?    13507           
  Misses            ?     6833           
  Partials          ?     1447

@thaJeztah
Copy link
Copy Markdown
Member Author

nice! It's green

@thaJeztah thaJeztah changed the title [do not merge] Bump golang 1.11beta1 [do not merge] Bump golang 1.11beta2 Jul 23, 2018
@thaJeztah
Copy link
Copy Markdown
Member Author

rebased, and updated to Go 1.11beta2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title [do not merge] Bump golang 1.11beta2 [do not merge] Bump golang 1.11beta3 Aug 7, 2018
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

closing, as this was handled through #2752

@thaJeztah thaJeztah closed this Mar 2, 2019
@thaJeztah thaJeztah deleted the bump_golang_1.11 branch March 2, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant