[18.03] Fix linting issues#2700
Merged
Merged
Conversation
Collaborator
|
LGTM |
Member
Author
|
Boo! |
4d054d5 to
aad90d6
Compare
Member
Author
|
Tried to force push to trigger CI, and got the same failure, however, doing a "dummy" PR against the 18.03 branch doesn't show that failure; #2701 Is something flaky in this test, or can it be triggered somehow by the changes here? |
Go 1.11 is stricter, and compilation will fail, revealing these issues; ``` agent/agent_test.go:120: *github.com/docker/swarmkit/api.WeightedPeer composite literal uses unkeyed fields agent/agent_test.go:125: *github.com/docker/swarmkit/api.WeightedPeer composite literal uses unkeyed fields agent/agent_test.go:130: *github.com/docker/swarmkit/api.WeightedPeer composite literal uses unkeyed fields agent/agent_test.go:135: *github.com/docker/swarmkit/api.WeightedPeer composite literal uses unkeyed fields agent/agent_test.go:140: *github.com/docker/swarmkit/api.WeightedPeer composite literal uses unkeyed fields manager/dispatcher/dispatcher.go:426: Entry.Info call has possible formatting directive %s manager/dispatcher/dispatcher.go:547: Entry.Debug call has possible formatting directive %s make: *** [vet] Error 1 ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 59064c3) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
aad90d6 to
ee05652
Compare
cyli
approved these changes
Jul 25, 2018
Contributor
cyli
left a comment
There was a problem hiding this comment.
LGTM - thanks @thaJeztah - TestNodeAllocator is known flakey.
Codecov Report
@@ Coverage Diff @@
## bump_v18.03 #2700 +/- ##
===============================================
- Coverage 61.82% 61.49% -0.33%
===============================================
Files 134 134
Lines 21820 21820
===============================================
- Hits 13491 13419 -72
- Misses 6888 6948 +60
- Partials 1441 1453 +12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #2693 for 18.03 branch
cherry-pick was clean; no conflicts
Go 1.11 is stricter, and compilation will fail, revealing these issues;
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit 59064c3)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to test it
- Description for the changelog