Skip to content

Bump coreos/etcd to v3.3.9 and go-systemd to v17#2718

Closed
vdemeester wants to merge 1 commit into
moby:masterfrom
vdemeester:bump-etcd-and-go-systemd
Closed

Bump coreos/etcd to v3.3.9 and go-systemd to v17#2718
vdemeester wants to merge 1 commit into
moby:masterfrom
vdemeester:bump-etcd-and-go-systemd

Conversation

@vdemeester
Copy link
Copy Markdown
Member

cc @chungers @mefyl

Signed-off-by: Vincent Demeester vincent@sbr.pm

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if green)

this will conflict with #2718, which also bumps go-systemd

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the bump-etcd-and-go-systemd branch from 05b0b9a to b6f64fe Compare July 27, 2018 09:50
@thaJeztah
Copy link
Copy Markdown
Member

TestNodeAllocator is a flaky test #2479 (and
#2700 (review))

time="2018-07-27T09:55:48Z" level=error msg="task allocation failure" error="failed to retrieve network testID3 while allocating task testTaskID3"
time="2018-07-27T09:55:49Z" level=error msg="Failed allocation for network testID5" error="failed while allocating driver state for network testID5: could not obtain vxlan id for pool 10.0.4.0/24: requested bit is already allocated"
time="2018-07-27T09:55:49Z" level=error msg="task allocation failure" error="network testID5 attached to task testTaskID6 not allocated yet"
time="2018-07-27T09:55:49Z" level=error msg="Failed allocation for service testServiceID4" error="requested bit is already allocated"
time="2018-07-27T09:55:49Z" level=error msg="task allocation failure" error="service testServiceID4 to which task testTaskID7 belongs has pending allocations"
--- FAIL: TestNodeAllocator (0.01s)
	allocator_test.go:1427: timed out before watchNode found expected node state
FAIL

@cpuguy83
Copy link
Copy Markdown
Member

This probably needs to upgrade testing as well as mixed-version testing as well.

@vdemeester vdemeester closed this Aug 22, 2018
@thaJeztah thaJeztah mentioned this pull request Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants