Correct fat pointer generation by codegen_rvalue_ref#101
Merged
markrtuttle merged 2 commits intomain-151-2021-04-26from Apr 26, 2021
Merged
Conversation
markrtuttle
force-pushed
the
correct-fat-pointers-in-codegen-rvalue-ref-mrtuttle
branch
from
7f60ca5 to
a6c0df5
Compare
danielsn
reviewed
Apr 26, 2021
Contributor
There was a problem hiding this comment.
It took me a second to realize that these are block comments for a bunch of code. Maybe distinguish that visually somehow?
danielsn
reviewed
Apr 26, 2021
Contributor
There was a problem hiding this comment.
It took me a second to realize that these are block comments for a bunch of code. Maybe distinguish that visually somehow?
danielsn
suggested changes
Apr 26, 2021
Contributor
danielsn
left a comment
danielsn
left a comment
There was a problem hiding this comment.
Mostly, looks great. For the first time, I think I understand what rvalue-ref is supposed to do.
My concern is the lack of tests. There is only one in this PR, which doesn't have any assertions.
- Would it be possible to add an assertion to that test?
- Are there other tests which already cover this functionality?
danielsn
changed the base branch from
main-151-2021-04-16
to
main-151-2021-04-26
Also restore the SizeAndAlignOfDst regression that now passes.
markrtuttle
force-pushed
the
correct-fat-pointers-in-codegen-rvalue-ref-mrtuttle
branch
from
a6c0df5 to
e3c12ff
Compare
danielsn
approved these changes
Apr 26, 2021
markrtuttle
deleted the
correct-fat-pointers-in-codegen-rvalue-ref-mrtuttle
branch
4 tasks
adpaco-aws
pushed a commit
that referenced
this pull request
May 5, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
May 10, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
May 26, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Jun 1, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Jun 23, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 2, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 9, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 6, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 17, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 24, 2021
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
celinval
pushed a commit
to celinval/kani-dev
that referenced
this pull request
Jan 12, 2022
* impl bitwise and & or
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Correct fat pointer generation by codegen_rvalue_ref Also restore the SizeAndAlignOfDst regression that now passes. * Respond to code review on correct fat pointer in codegen rvalue ref Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct fat pointer generation by codegen_rvalue_ref.
Also restore the SizeAndAlignOfDst regression that now passes.
Description of changes:
Describe RMC's current behavior and how your code changes that behavior. If there are no issues this PR is resolving, explain why this change is necessary.
Resolved issues:
Resolves #ISSUE-NUMBER
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.