Skip to content

Enforce formatting of RMC tests.#258

Merged
adpaco-aws merged 2 commits intomodel-checking:main-153-2021-06-23from
bdalrhm:fmt
Jun 23, 2021
Merged

Enforce formatting of RMC tests.#258
adpaco-aws merged 2 commits intomodel-checking:main-153-2021-06-23from
bdalrhm:fmt

Conversation

@bdalrhm
Copy link
Copy Markdown
Contributor

@bdalrhm bdalrhm commented Jun 23, 2021

Description of changes:

This PR enables formatting of RMC regressions.

Resolved issues:

Resolves #238

Call-outs:

In this project, the bootstrapper (not rustfmt) is in charge of parsing rustfmt.toml and deciding which files to format. Unlike rustfmt, however, the bootstrapper does not strictly follow the gitignore glob pattern format. This PR modifies the bootstrapper to follow gitignore format and make use of its patterns.

Testing:

  • How is this change tested?
    • rmc-regressions.sh now runs the formatting check on the tests
  • Is this a refactor change?
    • Yes. Some of the regressions needed reformatting

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws merged commit b4e6b02 into model-checking:main-153-2021-06-23 Jun 23, 2021
adpaco-aws pushed a commit that referenced this pull request Jul 2, 2021
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
adpaco-aws pushed a commit that referenced this pull request Jul 9, 2021
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
adpaco-aws pushed a commit that referenced this pull request Jul 15, 2021
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
adpaco-aws pushed a commit that referenced this pull request Jul 26, 2021
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
@bdalrhm bdalrhm deleted the fmt branch July 27, 2021 13:22
adpaco-aws pushed a commit that referenced this pull request Aug 2, 2021
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
@zhassan-aws zhassan-aws mentioned this pull request Aug 6, 2021
4 tasks
adpaco-aws pushed a commit that referenced this pull request Aug 6, 2021
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
adpaco-aws pushed a commit that referenced this pull request Aug 17, 2021
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
adpaco-aws pushed a commit that referenced this pull request Aug 24, 2021
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
tedinski pushed a commit that referenced this pull request Apr 27, 2022
* Enable formatting of rmc tests.

* Change expected line numbers for reformatted tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI should enforce rustfmt on tests

2 participants