Update dyn trait tests from raw to ptr Rust APIs#306
Merged
danielsn merged 1 commit intomodel-checking:main-153-2021-07-02from Jul 7, 2021
Merged
Update dyn trait tests from raw to ptr Rust APIs#306danielsn merged 1 commit intomodel-checking:main-153-2021-07-02from
danielsn merged 1 commit intomodel-checking:main-153-2021-07-02from
Conversation
adpaco-aws
approved these changes
Jul 7, 2021
Contributor
adpaco-aws
left a comment
adpaco-aws
left a comment
There was a problem hiding this comment.
Thanks! Merging this as soon as we can so #290 does not get blocked.
danielsn
approved these changes
Jul 7, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 9, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 15, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 26, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 2, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 6, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 17, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 24, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Rustc fully removed the deprecated raw API, we need to update our trait object tests to use the new pointer API:
rust-lang/rust@0d1919c
Resolved issues:
Resolves #305
Call-outs:
We should land this before attempting the next rebase.
Testing:
Updates to tests.
No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.