Change Default UI to New Display and Add UI Test Suite#828
Merged
jaisnan merged 8 commits intomodel-checking:mainfrom Feb 15, 2022
Merged
Change Default UI to New Display and Add UI Test Suite#828jaisnan merged 8 commits intomodel-checking:mainfrom
jaisnan merged 8 commits intomodel-checking:mainfrom
Conversation
Contributor
|
Does it make sense to add |
Contributor
Author
|
Yes, that change makes sense, this is a temporary fix for now. |
Contributor
This might make it difficult to write tests against other output formats. We'd have to see if multiple |
This was referenced Feb 21, 2022
Merged
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
…g#828) * Change expected files and add flags to explicitly demand old output * Fix issues with dry run and change default output to regular style * Add UI test suite
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Change expected files and add flags to explicitly demand old output * Fix issues with dry run and change default output to regular style * Add UI test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
expectedtest suite to use old format as a temporary fix.dry-rundidn't run well withexpectedThis is what calling
kanion a file looks like by default -Call-outs:
To get the old output display, pass the flag
--output-format old.The new output display has an issue where
--visualizedoesn't act well with the--output-formatflag. A fix is in the works.Testing:
How is this change tested? Added a new test suite
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.