Skip to content

Add a parameter (default off) to run_cmd to control whether to run the CBMC output parser#849

Merged
jaisnan merged 2 commits intomodel-checking:mainfrom
zhassan-aws:iss848
Feb 21, 2022
Merged

Add a parameter (default off) to run_cmd to control whether to run the CBMC output parser#849
jaisnan merged 2 commits intomodel-checking:mainfrom
zhassan-aws:iss848

Conversation

@zhassan-aws
Copy link
Copy Markdown
Contributor

Description of changes:

The --visualize option broke when we switched to the new UI (#828).

Resolved issues:

Resolves #848

Call-outs:

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner February 21, 2022 20:19
Copy link
Copy Markdown
Contributor

@tedinski tedinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will also be fixed by 738, but I have another round of comments on that

@jaisnan
Copy link
Copy Markdown
Contributor

jaisnan commented Feb 21, 2022

This change is a temporary fix while #738 gets merged , right?

@jaisnan jaisnan merged commit 831cb29 into model-checking:main Feb 21, 2022
@zhassan-aws
Copy link
Copy Markdown
Contributor Author

This change is a temporary fix while #738 gets merged , right?

Yes.

@zhassan-aws zhassan-aws deleted the iss848 branch February 21, 2022 21:12
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
tedinski pushed a commit that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The --visualize option is broken

3 participants