(hotfix): avoid error with large totim in returning budget dataframes#1677
Merged
jdhughes-dev merged 4 commits intoJan 23, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1677 +/- ##
=========================================
+ Coverage 71.6% 71.8% +0.2%
=========================================
Files 253 253
Lines 55881 55885 +4
=========================================
+ Hits 40053 40178 +125
+ Misses 15828 15707 -121
|
Contributor
|
You just need to run |
* update(Modpath7): update path construction for modflow model files in nam file * create relative path to flow model from modpath sim path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
totimis very large (like hundreds of years) theget_dataframesmethod formflistfilefails when trying to converttotimeto apandas.datetimeobject. This fix just uses a try-except to try converting to datetime and, if fails, just leavestotimas a float. @jlarsen-usgs - are there other methods that return dataframes with a time index? I suggest this fix could apply for them as well.