refactor: move project metadata to pyproject.toml#1678
Merged
Conversation
mwtoews
force-pushed
the
pyproject-metadata
branch
from
f586591 to
4cead8b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1678 +/- ##
=======================================
Coverage 71.6% 71.6%
=======================================
Files 253 253
Lines 55881 55881
=======================================
+ Hits 40053 40059 +6
+ Misses 15828 15822 -6
|
Member
|
Tested building the package from this PR branch and all seems good. I don't have maintainer permissions on the |
jdhughes-dev
pushed a commit
that referenced
this pull request
Jan 23, 2023
…#1677) * (hotfix): avoid error with large totim in returning budget dataframes * refactor: move project metadata to pyproject.toml (#1678) * update(Modpath7): update path construction for modpath nam file (#1679) * update(Modpath7): update path construction for modflow model files in nam file * create relative path to flow model from modpath sim path * ran isort and black Co-authored-by: Mike Taves <mwtoews@gmail.com> Co-authored-by: Joshua Larsen <jlarsen@usgs.gov>
wpbonelli
pushed a commit
that referenced
this pull request
Dec 2, 2024
The setup.py file was converted to a setuptools wrapper with #1678. This file is not used in this project, and modern pip/setuptools don't look for it anymore, so it can be cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the project metadata from setup.cfg to pyproject.toml as described by PEP 621 and implemented with setuptools >= 61.
Note that this metadata was previously moved with #1267, but setuptools did not support PEP 621 at the time.
This is mostly a 1:1 transfer, with a few exceptions:
python_version<'3.11'was removedThe remaining flake8 configuration from setup.cfg is simply moved to it's own configuration file.
Due to a GitHub bug, dependants are not listed for this project. Simply repeating the project name in setup.py will resolve this issue.