Skip to content

docs: add notebooks for modpath7 examples 3-4#1687

Merged
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:modpath-examples
Feb 24, 2023
Merged

docs: add notebooks for modpath7 examples 3-4#1687
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:modpath-examples

Conversation

@wpbonelli
Copy link
Copy Markdown
Member

@wpbonelli wpbonelli commented Jan 20, 2023

Add notebooks for problems 3 and 4 from the examples bundled with the MODPATH 7 distribution

  • example 3
  • example 4

Both examples are reproduced programmatically.

Could later be updated to compare MODPATH and PRT (when released)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2023

Codecov Report

Merging #1687 (5724880) into develop (7aa9ecf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1687   +/-   ##
=======================================
  Coverage     71.9%   71.9%           
=======================================
  Files          253     253           
  Lines        55987   55987           
=======================================
  Hits         40270   40270           
  Misses       15717   15717           

@wpbonelli wpbonelli force-pushed the modpath-examples branch 9 times, most recently from f8d45f3 to 5c68f10 Compare January 23, 2023 15:27
Comment thread examples/data/mp7/ex04_mf6/ex04_mf6.ims Outdated
Comment thread examples/data/mp7/ex04_mf6/ex04_mf6.ims Outdated
@wpbonelli wpbonelli force-pushed the modpath-examples branch 2 times, most recently from 474dad9 to 953b124 Compare January 23, 2023 17:19
@wpbonelli wpbonelli marked this pull request as ready for review January 23, 2023 17:20
@wpbonelli wpbonelli force-pushed the modpath-examples branch 4 times, most recently from 94c2029 to 94991b9 Compare February 3, 2023 17:32
@wpbonelli wpbonelli marked this pull request as draft February 13, 2023 04:57
@wpbonelli wpbonelli force-pushed the modpath-examples branch 4 times, most recently from 95ceb26 to c36ad2b Compare February 21, 2023 04:58
@wpbonelli wpbonelli marked this pull request as ready for review February 21, 2023 05:00
@wpbonelli wpbonelli force-pushed the modpath-examples branch 3 times, most recently from 3ceb258 to 75b1d14 Compare February 21, 2023 05:31
Copy link
Copy Markdown
Contributor

@jdhughes-dev jdhughes-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using edgecolor or facecolor will eliminte the warning in flopy_modpath7_structured_transient.ipynb which is causing the warning that is showing your file absolute path. Did we ever find a way to scrub this type of data?

If you reverse the order of your polygons in flopy_modpath7_unstructured_transient.ipynb will this eliminate the GeoJSON wayning?

@wpbonelli wpbonelli force-pushed the modpath-examples branch 2 times, most recently from 806f2d0 to 3ca8ed0 Compare February 21, 2023 16:24
@wpbonelli
Copy link
Copy Markdown
Member Author

Thanks @jdhughes-usgs, fixed warnings.

Absolute paths were cleaned up in #1711, but it looks like paths aren't always computed correctly now (e.g. executable paths in notebooks here). Opened #1728 to address

@wpbonelli wpbonelli force-pushed the modpath-examples branch 2 times, most recently from dc70c7f to 77cf268 Compare February 21, 2023 19:28
@wpbonelli
Copy link
Copy Markdown
Member Author

Fixed executable paths here as per approach proposed in 1728

@wpbonelli wpbonelli force-pushed the modpath-examples branch 2 times, most recently from 0e94237 to 1864d69 Compare February 22, 2023 17:55
Copy link
Copy Markdown

@christianlangevin christianlangevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @w-bonelli! Few minor things for your consideration.

  • "stress_period_data={0: dd, 1: dd, 2: dd}" If the drains are the same for every stress period, you only need to specify them for the first one and MODFLOW will automatically keep applying them.
  • The figure that uses the add_patches is a little confusing. The legend has color fill symbols, but not polygon symbols. And maybe features are overlying one another, but the I don't see all the legend colors on the plot. Maybe a combination of symbols and filled polygons would be best?
  • We often shrink the colorbar using shrink=0.5
  • The unstructured notebook looks great.

@wpbonelli wpbonelli force-pushed the modpath-examples branch 3 times, most recently from 09f16a5 to 4af705c Compare February 23, 2023 15:53
@wpbonelli
Copy link
Copy Markdown
Member Author

Thanks @langevin-usgs, just added revisions:

  • update drain stress period usage
  • shrink color bar by 0.5
  • fix legend/patch color consistency
  • lower alpha for heads on the last plot so patches can be seen more clearly
  • use plot_bc("WEL", plotAll=True) instead of custom patch to show wells
  • remove lingering username from output

@wpbonelli
Copy link
Copy Markdown
Member Author

Fixed pathline colors in existing notebooks to address #1732, also updated to suppress/capture model logs and avoid print statements showing executable path (per #1728)

@wpbonelli wpbonelli merged commit 94736c3 into modflowpy:develop Feb 24, 2023
@wpbonelli wpbonelli deleted the modpath-examples branch February 24, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants