docs: add notebooks for modpath7 examples 3-4#1687
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1687 +/- ##
=======================================
Coverage 71.9% 71.9%
=======================================
Files 253 253
Lines 55987 55987
=======================================
Hits 40270 40270
Misses 15717 15717 |
f8d45f3 to
5c68f10
Compare
474dad9 to
953b124
Compare
94c2029 to
94991b9
Compare
95ceb26 to
c36ad2b
Compare
3ceb258 to
75b1d14
Compare
Contributor
jdhughes-dev
left a comment
There was a problem hiding this comment.
Using edgecolor or facecolor will eliminte the warning in flopy_modpath7_structured_transient.ipynb which is causing the warning that is showing your file absolute path. Did we ever find a way to scrub this type of data?
If you reverse the order of your polygons in flopy_modpath7_unstructured_transient.ipynb will this eliminate the GeoJSON wayning?
806f2d0 to
3ca8ed0
Compare
Member
Author
dc70c7f to
77cf268
Compare
Member
Author
|
Fixed executable paths here as per approach proposed in 1728 |
0e94237 to
1864d69
Compare
christianlangevin
left a comment
There was a problem hiding this comment.
Looks great, @w-bonelli! Few minor things for your consideration.
- "stress_period_data={0: dd, 1: dd, 2: dd}" If the drains are the same for every stress period, you only need to specify them for the first one and MODFLOW will automatically keep applying them.
- The figure that uses the add_patches is a little confusing. The legend has color fill symbols, but not polygon symbols. And maybe features are overlying one another, but the I don't see all the legend colors on the plot. Maybe a combination of symbols and filled polygons would be best?
- We often shrink the colorbar using shrink=0.5
- The unstructured notebook looks great.
09f16a5 to
4af705c
Compare
Member
Author
|
Thanks @langevin-usgs, just added revisions:
|
4af705c to
875127c
Compare
8900393 to
5724880
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add notebooks for problems 3 and 4 from the examples bundled with the MODPATH 7 distribution
Both examples are reproduced programmatically.
Could later be updated to compare MODPATH and PRT (when released)