Skip to content

update(notebooks, mfhob.py): clean paths in jupyter notebooks#1711

Merged
jlarsen-usgs merged 13 commits into
modflowpy:developfrom
jlarsen-usgs:develop
Feb 16, 2023
Merged

update(notebooks, mfhob.py): clean paths in jupyter notebooks#1711
jlarsen-usgs merged 13 commits into
modflowpy:developfrom
jlarsen-usgs:develop

Conversation

@jlarsen-usgs
Copy link
Copy Markdown
Contributor

  • update export_utils.py to echo relative paths
  • update export/utils.py to echo relative paths
  • update echoed executable path in run_models
  • update ModflowHob.load() to use flopy_io.line_strip()

* update export_utils.py to echo relative paths
* update export/utils.py to echo relative paths
* update echoed executable path in run_models
* update ModflowHob.load() to use flopy_io.line_strip()
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 7, 2023

Codecov Report

Merging #1711 (aeed97f) into develop (2552de5) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #1711   +/-   ##
=======================================
  Coverage     71.9%   71.9%           
=======================================
  Files          253     253           
  Lines        55891   55904   +13     
=======================================
+ Hits         40202   40219   +17     
+ Misses       15689   15685    -4     
Impacted Files Coverage Δ
flopy/export/shapefile_utils.py 90.5% <100.0%> (ø)
flopy/export/utils.py 65.3% <100.0%> (-0.1%) ⬇️
flopy/mbase.py 69.1% <100.0%> (+<0.1%) ⬆️
flopy/modflow/mfhob.py 88.9% <100.0%> (+<0.1%) ⬆️
flopy/utils/check.py 75.7% <100.0%> (+<0.1%) ⬆️
flopy/utils/flopy_io.py 79.2% <100.0%> (+0.9%) ⬆️
flopy/utils/get_modflow.py 63.9% <0.0%> (+0.9%) ⬆️

Provide a workaround for Python issue # 7195, cannot produce a relative path across windows drives
Comment thread examples/Notebooks/flopy3_ModelCheckerExample.ipynb Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants