refactor(expired deprecation): remaining references to SpatialReference#1914
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1914 +/- ##
=======================================
Coverage 72.5% 72.6%
=======================================
Files 257 257
Lines 56279 56210 -69
=======================================
- Hits 40854 40841 -13
+ Misses 15425 15369 -56
|
wpbonelli
approved these changes
Aug 10, 2023
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Nov 18, 2024
The deprecated module contains spatial reference classes similar to those deprecated/removed in modflowpy#1914, modflowpy#1892, and modflowpy#1200. These are not in use anywhere in the codebase. The flopy.discretization module can be used instead.
wpbonelli
added a commit
that referenced
this pull request
Nov 19, 2024
…2375) The flopy.mf6.utils.reference module contains spatial reference classes similar to those deprecated/removed in #1914, #1892, and #1200. These are not in use anywhere in the codebase. The flopy.discretization module can/should be used instead. --------- Co-authored-by: Mike Taves <mwtoews@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans-up a few remaining references to SpatialReference or related (e.g. "sr"). This extends beyond #1200 and #1892.
Details of changes:
_set_sr_coord_infofromflopy/discretization/grid.pyflopy/modflow/mfdis.pywas not actually ignored, but now it actually is ignored and removed, as this should be in classic NAM filesNote that these changes are not related to
flopy.mf6.utils.reference.SpatialReference, which is not deprecated.