refactor(deprecations): deprecate flopy.mf6.utils.reference module#2375
Merged
Conversation
The deprecated module contains spatial reference classes similar to those deprecated/removed in modflowpy#1914, modflowpy#1892, and modflowpy#1200. These are not in use anywhere in the codebase. The flopy.discretization module can be used instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2375 +/- ##
=========================================
+ Coverage 68.4% 75.9% +7.5%
=========================================
Files 294 294
Lines 59390 61638 +2248
=========================================
+ Hits 40652 46841 +6189
+ Misses 18738 14797 -3941
|
mwtoews
approved these changes
Nov 18, 2024
Contributor
mwtoews
left a comment
There was a problem hiding this comment.
Sure, looks good. I've pushed a commit to use Sphinx's cross-references.
jdhughes-dev
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
flopy.mf6.utils.referencemodule contains spatial reference classes similar to those deprecated/removed in #1914, #1892, and #1200. These are not in use anywhere in the codebase. Theflopy.discretizationmodule can/should be used instead?