PYTHON-2480: Add MongoClient helper to access the current TopologyDescription #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantmital
suggested changes
Mar 22, 2021
Contributor
prashantmital
left a comment
prashantmital
left a comment
There was a problem hiding this comment.
Since we are adding a public property we also want to add something to test_client.py that would result in a failure if we ever inadvertently removed this property from MongoClient. The simplest( and most naive) approach to testing this would be to add a test to ClientUnitTest that checks that client.topology_description returns the same object as client._topology._description.
ShaneHarvey
reviewed
Mar 23, 2021
Member
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
Great work. Just one quick ask.
prashantmital
suggested changes
Mar 23, 2021
ShaneHarvey
reviewed
Mar 23, 2021
| self.assertFalse(c.secondaries) | ||
| c = rs_or_single_client(connect=False) | ||
| self.assertIsInstance(c.max_write_batch_size, int) | ||
| self.assertIsInstance(c.topology_description, TopologyDescription) |
prashantmital
approved these changes
Mar 24, 2021
ShaneHarvey
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property for accessing current topology description in MongoClient.
Open Questions:
How to test these changes/run locally?