-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-2480: Add MongoClient helper to access the current TopologyDescription #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
791abcd
add topology description getter
guanlinzhou 1db39cf
add test
guanlinzhou 2bfc5d4
added docs
guanlinzhou f7198fc
added docs
guanlinzhou deb30b6
update to 4.0
guanlinzhou b24c8e8
added server description to index
guanlinzhou 8110535
nits
guanlinzhou 408ace8
update documentation
guanlinzhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,6 +62,7 @@ | |
| from pymongo.server_type import SERVER_TYPE | ||
| from pymongo.settings import TOPOLOGY_TYPE | ||
| from pymongo.topology import _ErrorContext | ||
| from pymongo.topology_description import TopologyDescription | ||
| from pymongo.srv_resolver import _HAVE_DNSPYTHON | ||
| from pymongo.write_concern import WriteConcern | ||
| from test import (client_context, | ||
|
|
@@ -597,6 +598,8 @@ def test_init_disconnected(self): | |
| self.assertFalse(c.secondaries) | ||
| c = rs_or_single_client(connect=False) | ||
| self.assertIsInstance(c.max_write_batch_size, int) | ||
| self.assertIsInstance(c.topology_description, TopologyDescription) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nicely done. |
||
| self.assertEqual(c.topology_description, c._topology._description) | ||
|
|
||
| if client_context.is_rs: | ||
| # The primary's host and port are from the replica set config. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.