feat(backends): extract shared env filtering into src/backends/shared/envFilter.ts#832
Merged
feat(backends): extract shared env filtering into src/backends/shared/envFilter.ts#832
Conversation
nhopeatall
approved these changes
Mar 14, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - the shared env filtering extraction preserves the existing allow/block behavior across engines, keeps engine-specific auth vars isolated, and is covered by the existing Claude env tests plus the new shared filter unit suite. I also verified the cited unit test slice passes locally and npm run typecheck completes cleanly.
🕵️ codex · gpt-5.4 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/backends/shared/envFilter.tsexportingSHARED_BLOCKED_ENV_EXACT,SHARED_ALLOWED_ENV_EXACT,SHARED_ALLOWED_ENV_PREFIXES, and a parameterisedfilterProcessEnv()that defaults to the shared setsclaude-code/env.ts,codex/env.ts, andopencode/env.tsto import and reuse the shared sets — each engine only adds its own auth varstests/unit/backends/shared-envFilter.test.tswith 19 tests covering blocklist, allowlist, prefix matching, and custom-set override pathsclaude-code-env.test.tstests continue to pass (zero behaviour changes)Card: https://trello.com/c/0EEDxGm2/348-as-a-developer-i-want-shared-env-filtering-so-that-envts-duplication-across-engines-is-eliminated
Test plan
npm run test:unit -- --run tests/unit/backends/claude-code-env.test.ts tests/unit/backends/shared-envFilter.test.ts— 34 tests passnpm run typecheck— zero errorsnpm run lint— zero errors🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details