Skip to content

Add the option to add a special class to datapoints#507

Open
JelteF wants to merge 1 commit into
morrisjs:masterfrom
JelteF:special-class
Open

Add the option to add a special class to datapoints#507
JelteF wants to merge 1 commit into
morrisjs:masterfrom
JelteF:special-class

Conversation

@JelteF
Copy link
Copy Markdown
Contributor

@JelteF JelteF commented Oct 8, 2014

This way you can style them differently, like making the label bold or a different color. Or make some bar more visible than others.

@sudodoki
Copy link
Copy Markdown
Contributor

sudodoki commented Oct 8, 2014

I can tell there's odd change in gruntfile. As to API I would suggest adding classFor callback

@JelteF
Copy link
Copy Markdown
Contributor Author

JelteF commented Oct 8, 2014

Oh, stupid mistake. I added that for testing myself. And I'll look into the callback, think I've missed that one

@sudodoki
Copy link
Copy Markdown
Contributor

sudodoki commented Oct 8, 2014

There's none, just a suggestion to what this feature might look like: classFor callback in your options.

@JelteF
Copy link
Copy Markdown
Contributor Author

JelteF commented Oct 15, 2014

I changed it to a callback named barClass to have the same type of interface as the barColors callback.

@JelteF JelteF added the feature label Oct 15, 2014
pierresh pushed a commit to pierresh/morris.js that referenced this pull request Nov 6, 2018
Related to these discussion threads
morrisjs#507
#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants