Animation on linechart enter#7
Closed
schirrel wants to merge 2 commits into
Closed
Conversation
Addingclassto attrs so it'll be animated with the new css
pierresh
pushed a commit
that referenced
this pull request
Nov 6, 2018
Related to these discussion threads morrisjs#507 #7
Owner
|
Hi Alan, thanks a lot for this pull request and sorry for my late reply. Your "in-line" animation is very interesting and definitively makes sense. Nevertheless, as it is mostly done of CSS (and therefore not really configurable), I suppose it is better to give flexibility, which CSS class has to be used per chart. That is why I just added new 2 options extraClassLine and extraClassCircle to define the extra class to be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in my old morris fork (moved to https://github.com/schirrel/morris.js) i had add someanimation online chart enter
alsoby that time i have made and formater for the value to show only inlegend, as far as i saw its similar to you hover callback, thus i dont think still interesting
great job done there pierre